Add Freedesktop files

[hfiguiere]

Add and install the freedesktop files.

I use them for the flatpak flathub/flathub#1626

[dvzrv]

Good stuff! @monocasual please include this

[monocasual]

@hfiguiere thanks! Sorry for the delay, we were super busy with the CMake port. Two issues:

1. could you please apply the changes in the CMakeLists.txt file? The Makefile.am/Configure.ac stuff is dead now (luckily 😎 )
2. We are using the following Desktop file for the AppImage package:

[Desktop Entry]
Name=Giada
Name[es]=Giada
GenericName=Drum machine and loop sequencer
GenericName[es]=Caja de ritmos y secuenciador de loops
Icon=giada
Type=Application
Exec=giada
Terminal=false
Categories=AudioVideo;Audio;X-Digital_Processing;X-Jack;X-MIDI;Midi;
Keywords=Giada;

Do you think it can be safely merged into the one you proposed?

[hfiguiere]

@hfiguiere thanks! Sorry for the delay, we were super busy with the CMake port. Two issues:

1. could you please apply the changes in the `CMakeLists.txt` file? The `Makefile.am`/`Configure.ac` stuff is dead now (luckily sunglasses )

I have no clue on how to do that in CMake.

2. We are using the following Desktop file for the AppImage package:

I couldn't find the .desktop file but I have merged most of the one below into the one I am submitting.

[monocasual]

I couldn't find the .desktop file but I have merged most of the one below into the one I am submitting.

Perfect.

I have no clue on how to do that in CMake.

The problem is that we are about to get rid of Autotools very soon (#396). What do variables such as desktopdir, desktop_DATA, appdatadir, appdata_DATA, ... do? They are defined in Makefile.am but (apparently) not used anywhere. With a bit of more context I could try to translate them into CMake commands.

[hfiguiere]

The problem is that we are about to get rid of Autotools very soon (#396). What do variables such as desktopdir, desktop_DATA, appdatadir, appdata_DATA, ... do? They are defined in Makefile.am but (apparently) not used anywhere. With a bit of more context I could try to translate them into CMake commands.

This is standard automake syntax. "something_DATA" list data files to be installed into "somethingdir". So in that case:

destkop_DATA -> desktopdir, appdata_DATA -> appdatadir

They are used by automake that will generate the proper install targets.

And this is in my patch, protected by an AM_CONDITIONAL that is set if the platform is Linux or BSD because it's only relevant on not (Windows or macOS).

[hfiguiere]

And the files are listed in EXTRA_DIST so that a make dist always add them to the tarball whichever the platform make dist is run on.

[monocasual]

I see, thanks @hfiguiere for the explanation. So I guess this should be covered by CMake installation rules and CPack for packaging (the make dist part).

[dvzrv]

@monocasual As the cmake setup is not yet complete, it would have been nice to include this into the currently working setup.
As the ticket for the cmake installation target is still open, integrating it there should not be much harder either.

[monocasual]

@dvzrv the problem here is that we still have to figure out how to translate that automake syntax into cmake commands. Any hint would be appreciated.

[musicinmybrain]

I am not a CMake expert, so I can’t help with that part unless I have some time to dive through the documentation. I just wanted to note that I am updating the giada package in Fedora Linux, and I am using the files from this PR in the package.

[hfiguiere]

Having them in the upstream repository even without install would help a lot.

Maybe I'll just update the PR with these files alone.

(I use them for the Flatpak)

[musicinmybrain]

Using these in a GNOME/Wayland session, a generic icon and name (“FLTK”) are shown. This is a common problem, and it is not caused by any problem with the appdata and desktop file; instead, the program needs to find a way to set the application ID.

See spyder-ide/spyder#13786 for a detailed writeup of the same issue in a different application. Unfortunately the fix there was Qt-specific. Similarly for LyX and frescobaldi. See also https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/950, which is related.

This is not a deal-breaker for using these files, as having the correct launcher is much better than nothing. However, I’m hoping someone can figure out the right source code patch to allow gnome-shell to match the window with the desktop file.

[hfiguiere]

Now with this update of the patch, the files get installed with CMake, including the icons

[gvnnz]

@hfiguiere thanks a lot for the update, I've just added a couple of comments.

[gvnnz]

Merged to freedesktop-files branch. I have fixed few minor things here and there, @hfiguiere please let me know if it looks good to you.

[hfiguiere]

The change of app-id is unfortunate, and even I don't see it being necassary since you have the domain as well. This will translate to have to keep patches for the flathub package.

[gvnnz]

@hfiguiere changes reverted. Green light?

[hfiguiere]

looks ok to me

[gvnnz]

Merged manually. Thanks!