Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query calls currently registered stream_handler, not default stream #463

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

trentgill
Copy link
Collaborator

@dndrks this should solve the issue in the norns .query request: monome/norns#1555

issue is that the new norns handling doesn't use the old 'named' convention (eg. ^^stream) but instead allocates a dynamic name under the hood. the change was made such that future API changes on crow wouldn't require a co-edit to the norns system (ie. it would 'just work').

@dndrks
Copy link
Member

dndrks commented Apr 5, 2022

raaaad, thanks @trentgill !
what do you think about bundling a new crow update for this and the other rad bits you've deployed since last july?

@trentgill
Copy link
Collaborator Author

i'm honestly not sure if it's working correctly atm. i merged a bunch of changes that i think may have introduced some instability in the system (and more liklihood for crashes after using a large script for a while). if folks have some time to run some tests & general usage then i'd be confident pushing it out -- i just don't have the cycles right now to handle a situation where the update causes issues for a bunch of people.

in the meantime, this particular issue can be solved by adding the following lines to a norns script:

crow.send("input[1].query = function() stream_handler(1, input[1].volts) end")
crow.send("input[2].query = function() stream_handler(2, input[2].volts) end")

(untested).

dndrks added a commit to monome/docs that referenced this pull request Sep 7, 2022
addressed in github issue: monome/crow#463
@dndrks dndrks deleted the fix-query branch July 25, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants