Allow using system installed libuv #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonvanderveldt
changed the title
Instead of the included git submodule. Can be enabled using the configure flag --enable-system-libuv
simonvanderveldt
force-pushed
the
allow-using-system-libuv
branch
from
70e4ccb
to
6afa263
Compare
|
👌 thanks :) |
|
merged (with rewritten commit msg) as b1e9a64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the included git submodule.
Can be enabled using the configure flag
--enable-system-libuvThis fixes #30
@wrl I went for an explicit configure option instead of "magic" based on if the submodule would or wouldn't exist. IMHO this is a bit cleaner plus it allows the build to fail when the packager wants to use the system libuv and it isn't installed (and the git submodule is checked out).
Also, I didn't make the flag Linux specific since libuv can be installed systemwide on both macOS (http://formulae.brew.sh/formula/libuv) and Windows (https://www.nuget.org/packages/Libuv/).