-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JI op rework #136
JI op rework #136
Conversation
See the thread here |
@tehn @trentgill could you take a look? |
Code looks good to me. I think a short note should be added to CHANGELOG.md stating how the op has changed behaviour. Also, I'm not sure if JI is even in the docs yet, but if so, it's description will need to be updated too. How can we pull the code that generates |
could they be generated with a python script? we could add it to |
for what its worth it might make sense to just put table generating code right next to the source itself such as was done in libavr32 for the euclidean data table: |
The generator is really simple (here in C), though uses logf() so it's not created at runtime: So I think inline would be best. I didn't do that in the first place because JI is already the longest op, and there's no other block comments in the relevant file. If someone wants to translate to Python that's fine by me too. |
agreed it's best to have it in the source file itself. @simondemeule could you add it to your PR (and also include an update for CHANGELOG.md as mentioned)? |
Here we go! |
Fixed my entry not being under v2.2
Merged because of a conflict in the changelog. |
Removed octave-wrapping behaviour. Now returns exactly the entered
ratio.