Refactoring of the RepositoryDatasource class and add a datasource for the products #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delyriand
requested review from
jacquesbh,
maximehuran and
etienne-monsieurbiz
delyriand
force-pushed
the
feature/product-datasource
branch
from
ada947e
to
2ef2aee
Compare
maximehuran
approved these changes
Jan 30, 2023
etienne-monsieurbiz
approved these changes
Jun 26, 2023
delyriand
force-pushed
the
feature/product-datasource
branch
from
2ef2aee
to
972499d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new product data source only returns activated products that have a channel to index them in ES.
And I refactored the RepositoryDatasource, it always works with a pagnitor. I increase the batch size, by default is 10.
Example
Example, my product with id 10, doesn't have channels:
but it is indexed in ES:
With the new datasource, the product is not indexing:
