Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - optgroup support #1133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Feb 15, 2013

  1. Option element conversion to contentController objects now honor text…

    …PropertyPath and valuePropertyPaths, if available
    
    select.reel honors the valuePropertyPath and textPropertyPath when converting a passed in contentController to <option> tags, but does not honor the reverse. If an <option> tag is present, it doesn't convert value and text values into corresponding valuePropertyPath and textPropertyPath properties on the generated objects.
    
    This fixes that by using the valuePropertyPath ad textPropertyPath values when present and defaulting to "value" and "text" when they're not present.
    
    Signed-off-by: Tom Ortega <tom.ortega@gmail.com>
    lordbron committed Feb 15, 2013
    Configuration menu
    Copy the full SHA
    bfb94ff View commit details
    Browse the repository at this point in the history
  2. optgroup nodes no longer ignored when reading in from markup

    select.reel ignores optgroup when creating objects to stash in the contentController it creates to stash the values; This results in the groups disappearing in the drop down.
    
    This fixes that by creating introducing a groupPropertyPath property and maintaining an offset value to use when calculating selected indexes of selected options.
    
    Signed-off-by: Tom Ortega <tom.ortega@gmail.com>
    lordbron committed Feb 15, 2013
    Configuration menu
    Copy the full SHA
    566b4dd View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2013

  1. when existing options have no group labels

    This fix is for when existing options have no 'groupLabel' nor groupPropertyPath on them.
    
    This drops it back out of a group and back into regular option tags.
    
    Signed-off-by: Tom Ortega <tom.ortega@gmail.com>
    lordbron committed Feb 19, 2013
    Configuration menu
    Copy the full SHA
    1a4df21 View commit details
    Browse the repository at this point in the history