V0.6 #93
Merged
V0.6 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he slot content When the content of the slot is needsDraw=true and set an element it is not being added to the draw loop because it is not part of the component tree since its element isn't in the DOM yet. When the content is finally added to the component tree needsDraw=true doesn't have any effect anymore because it is already in that state, never making it to the draw cycle ever again. This will be correctly addressed in master.
francoisfrisch
pushed a commit
that referenced
this pull request
Feb 6, 2012
Temporary fix to slot drawing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ent
When the content of the slot is needsDraw=true and set an element it is not being added to the draw loop because it is not part of the component tree since its element isn't in the DOM yet.
When the content is finally added to the component tree needsDraw=true doesn't have any effect anymore because it is already in that state, never making it to the draw cycle ever again.
This will be correctly addressed in master.