Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitution inside Repetition not rendering at all #92

Closed
eliseosoto opened this issue Feb 3, 2012 · 11 comments
Closed

Substitution inside Repetition not rendering at all #92

eliseosoto opened this issue Feb 3, 2012 · 11 comments
Assignees
@eliseosoto
Milestone
M7

Comments

@eliseosoto
Copy link
Collaborator

See this example

One more thing, I added a logger to see the contents of switchComponents inside the substitution and I get this:

log

Notice that text is not an Object, is directly taking text.value. Also notice that the switchComponent is wrapped inside a <div> only if it's an Object.

DOM

Maybe related to #91
@ghost ghost assigned aadsm Feb 3, 2012
@marchant
Copy link
Member

marchant commented Feb 3, 2012

Afonso, assigned to you as it could be related to your changes

aadsm added a commit to aadsm/montage that referenced this issue Feb 4, 2012
@aadsm
[montagejsgh-92] Add workaround for an issue related to the draw of t…
7b1ebb5 
…he slot content

When the content of the slot is needsDraw=true and set an element it is not being added to the draw loop because it is not part of the component tree since its element isn't in the DOM yet.

When the content is finally added to the component tree needsDraw=true doesn't have any effect anymore because it is already in that state, never making it to the draw cycle ever again.

This will be correctly addressed in master.
@aadsm
Copy link
Collaborator

aadsm commented Feb 4, 2012

Besides the fix I just pushed and asked for a pull request there's an error in that example.
When defining an entry in the serialization you can only either use "value" or the "module"/"name" pair but not both at the same time, it will be interpreted as the contents of "value" and not as an object, that's why you were seeing the "XX".

@marchant
Copy link
Member

marchant commented Feb 6, 2012

Eliseo, did you verify with the change?

@eliseosoto
Copy link
Collaborator Author

Hi, yes. I verified the fix and it works.

However I still have a problem with the List component. I think it's being addressed on #91

@francoisfrisch
Copy link
Contributor

commit has been merged into v0.6 #93

@eliseosoto eliseosoto mentioned this issue Feb 9, 2012
Closed
@marchant
Copy link
Member

This is still open as a correct fix still need to be found -> #130

@ghost ghost assigned heatherdouglass Feb 15, 2012
This was referenced Feb 22, 2012
Closed
Merged
@heatherdouglass
Copy link
Collaborator

The fix for this is waiting to be reviewed and pulled into master in gh-217.

@heatherdouglass
Copy link
Collaborator

This change is available on master, @eliseosoto can you verify? Thanks.

@ghost ghost assigned eliseosoto Feb 29, 2012
@eliseosoto
Copy link
Collaborator Author

Tested screening with the current Montage master and it works. Is there anything new in master related to this issue? Because everything started working for me since the final v0.6

@heatherdouglass
Copy link
Collaborator

There was a work around in place in the v0.6 branch, but the work around should not have been present in master. I added an API for setting an element with a parentComponent on a component and updated the slot to use this API in master, but this change was only merged earlier today.

@eliseosoto
Copy link
Collaborator Author

Ok, since this solves my issue I'll close this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliseosoto eliseosoto

Labels
None yet
Projects
None yet
Milestone
M7
Development

No branches or pull requests
5 participants
@aadsm @eliseosoto @marchant @francoisfrisch @heatherdouglass