Remove logic from NativeControls.deserializedFromTemplate and hook off the element's setter #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 3, 2012 11:50
…turn the same value.
…e to the setter of the element property
…. Eg: phone # field in the input-text-example.html
…ativeControl prototype chain
| //var component = Object.getPrototypeOf(NativeControl); | ||
| // call super set | ||
| Object.getPropertyDescriptor(Component, "element").set.call(this, value); | ||
| this._elementSet(); |
There was a problem hiding this comment.
I think we should be using didSetElement for this.
https://github.com/Motorola-Mobility/montage/blob/master/ui/component.js#L1781
There was a problem hiding this comment.
Changed to didSetElement.
| @function external:String.isString() | ||
| @param {object} obj The object to determine if its a String. | ||
| @returns {boolean} Object.prototype.toString.call(obj) === "[object String]" | ||
| */ |
There was a problem hiding this comment.
Wondering why is typeof(obj) === 'string' not enough?
There was a problem hiding this comment.
It might be because of the following reason:
- typeof "foo" -> "string"
But typeof (new String('foo')) -> "object" - Object.prototype.toString.call("foo") -> "[object String]"
- Object.prototype.toString.call(new String('foo')) -> "[object String]"
The 2nd option is more correct regardless of whether the String value or String Object is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logic from deserializedFromTemplate to _elementSet which is invoked on element.setter. Since the element setter is called before the binding occurs, I also made some changes to handle this.
@francoisfrisch: Also includes implementing attribute properties on the prototype chain.