Skip to content

Commit

Permalink
Add Category for Today's Event (#295)
Browse files Browse the repository at this point in the history
* add category for today events

* modify seeds to require factory_bot

* fix event index issue when no events exist
  • Loading branch information
shalstein authored and sophiedeziel committed Nov 10, 2018
1 parent da73e3d commit d094ab8
Show file tree
Hide file tree
Showing 7 changed files with 65 additions and 5 deletions.
17 changes: 15 additions & 2 deletions app/controllers/events_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,25 @@

class EventsController < ApplicationController
def index
@past_events, @future_events = Event.published.includes(
grouped_events = Event.published.includes(
:translations,
:location,
:talks,
:sponsors
).partition { |e| e.starts_at < Time.now }
).order(:starts_at).group_by do |event|
if event.starts_at < Date.today
:past
elsif event.starts_at.to_date == Date.today
:today
else
:future
end
end

@past_events, @todays_event, @future_events = grouped_events.values_at(
:past, :today, :future
)

end

def show
Expand Down
17 changes: 15 additions & 2 deletions app/controllers/home_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,24 @@

class HomeController < ApplicationController
def index
@past_events, @future_events = Event.published.includes(
grouped_events = Event.published.includes(
:translations,
:location,
:sponsors,
talks: %i(member translations)
).order(:starts_at).limit(5).partition { |e| e.starts_at < Time.now }
).order(:starts_at).limit(5).group_by do |event|
if event.starts_at < Date.today
:past
elsif event.starts_at.to_date == Date.today
:today
else
:future
end
end
@past_events, @todays_event, @future_events = grouped_events.values_at(
:past, :today, :future
)

end

end
12 changes: 11 additions & 1 deletion app/views/events/index.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
<% provide :title, "Events" %>
<% if @future_events.any? %>
<% if @todays_event %>
<h1>Today's Event</h1>

<div class='todays-event'>
<%= render @todays_event %>
</div>

<% end %>
<% if @future_events %>
<h1>Upcoming <%= 'Event'.pluralize(@future_events.count) %></h1>

<div class='future-events'>
Expand Down
12 changes: 12 additions & 0 deletions spec/controllers/events_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
let!(:scheduled_event) { create(:event, :scheduled, starts_at: Date.tomorrow) }
let!(:past_event) { create(:event, :scheduled, starts_at: 1.month.ago) }
let!(:future_event) { create(:event, :scheduled, starts_at: 1.month.from_now) }
let!(:today_event) { create :event, :scheduled, starts_at: DateTime.now}

describe "GET #index" do
before :each do
Expand All @@ -24,6 +25,7 @@
it "does not include proposed events" do
expect(assigns(:past_events)).not_to include proposed_event
expect(assigns(:future_events)).not_to include proposed_event
expect(assigns(:todays_event)).not_to include proposed_event
end

it "renders the :index template" do
Expand All @@ -33,11 +35,21 @@
it "gets past events" do
expect(assigns(:past_events)).to include past_event
expect(assigns(:past_events)).not_to include future_event
expect(assigns(:past_events)).not_to include today_event

end

it "gets future events" do
expect(assigns(:future_events)).to include future_event
expect(assigns(:future_events)).not_to include past_event
expect(assigns(:future_events)).not_to include today_event
end

it "gets todays event" do
expect(assigns(:todays_event)).to include today_event
expect(assigns(:todays_event)).not_to include past_event
expect(assigns(:todays_event)).not_to include future_event

end
end

Expand Down
1 change: 1 addition & 0 deletions spec/features/authentication_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
RSpec.describe "Authentication" do
let(:user) { create(:user) }
let(:admin) { create(:user, :admin) }
let!(:past_event) { create :event, :scheduled, starts_at: 1.month.ago }

context "Guest user" do
scenario "Can sign up", vcr: { match_requests_on: [
Expand Down
1 change: 1 addition & 0 deletions spec/features/sign_up_with_twitter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
' do

describe "access to questions index" do
let!(:past_event) { create :event, :scheduled, starts_at: 1.month.ago }
background do
visit root_path
click_on "Log in"
Expand Down
10 changes: 10 additions & 0 deletions spec/views/events/index.html.erb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
let!(:future_event) { create :event, :scheduled, starts_at: 1.month.from_now }
let!(:past_event) { create :event, :scheduled, starts_at: 1.month.ago }


before do
assign :future_events, [future_event]
assign :past_events, [past_event]
Expand All @@ -31,6 +32,15 @@
end
end

context "there are no events today" do
before { assign :today_event, [] }

it "does not display anything about today's events" do
render
expect(rendered).not_to have_css "h1", text: "Today's Event"
end
end

context "event has a talk" do
let(:member) { create :member }
let!(:talk) { create :talk, state: "scheduled", event: past_event, member: member }
Expand Down

0 comments on commit d094ab8

Please sign in to comment.