Double default memory request to 100Mi

monzo · Aug 1, 2023 · 6233439 · 6233439
1 parent 78bf67f
commit 6233439
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -100,7 +100,7 @@ spec:
   maxReplicas: 10
   # optional, defaults to 50
   targetCPUUtilizationPercentage: 30
-  # optional, if not provided then defaults to 100m, 50Mi, 2, 1Gi
+  # optional, if not provided then defaults to 100m, 100Mi, 2, 1Gi
   resources:
     requests:
       cpu: 1

diff --git a/api/v1/externalservice_types.go b/api/v1/externalservice_types.go
@@ -46,7 +46,7 @@ type ExternalServiceSpec struct {
 	// +optional
 	TargetCPUUtilizationPercentage *int32 `json:"targetCPUUtilizationPercentage,omitempty"`
 
-	// ResourceRequirements describes the compute resource requirements for gateway pods. Defaults to 100m, 50Mi, 2, 1Gi
+	// ResourceRequirements describes the compute resource requirements for gateway pods. Defaults to 100m, 100Mi, 2, 1Gi
 	// +optional
 	Resources *v1.ResourceRequirements `json:"resources,omitempty"`
 

diff --git a/config/crd/bases/egress.monzo.com_externalservices.yaml b/config/crd/bases/egress.monzo.com_externalservices.yaml
@@ -77,7 +77,7 @@ spec:
                 type: array
               resources:
                 description: ResourceRequirements describes the compute resource requirements
-                  for gateway pods. Defaults to 100m, 50Mi, 2, 1Gi
+                  for gateway pods. Defaults to 100m, 100Mi, 2, 1Gi
                 properties:
                   claims:
                     description: "Claims lists the names of resources, defined in

diff --git a/controllers/deployment.go b/controllers/deployment.go
@@ -98,7 +98,7 @@ func deployment(es *egressv1.ExternalService, configHash string) *appsv1.Deploym
 		resources = corev1.ResourceRequirements{
 			Requests: corev1.ResourceList{
 				"cpu":    resource.MustParse("100m"),
-				"memory": resource.MustParse("50Mi"),
+				"memory": resource.MustParse("100Mi"),
 			},
 			Limits: corev1.ResourceList{
 				"cpu":    resource.MustParse("2"),