Upgrade various k8s.io + kubebuilder dependencies #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesbxf
changed the title
milesbxf
force-pushed
the
upgrade-client-go
branch
from
067f976
to
2906ee8
Compare
milesbxf
commented
Jul 18, 2023
| @@ -145,7 +146,7 @@ func assertState(key types.NamespacedName, es *v1.ExternalService) { | |||
|
|
|||
| return d | |||
| }, timeout, interval).Should(And( | |||
| WithTransform(func(d *appsv1.Deployment) appsv1.DeploymentSpec { return d.Spec }, Equal(deployment(es, cHash).Spec)), | |||
| WithTransform(func(d *appsv1.Deployment) appsv1.DeploymentSpec { return d.Spec }, BeComparableTo(deployment(es, cHash).Spec)), | |||
There was a problem hiding this comment.
BeComparableTo is like Equal except it uses go-cmp under the hood instead of DeepCopy - this makes it much easier to see the actual object diff
adamflanagan
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's about time we did this! Updates:
We need this in order to add PDBs in newer clusters. The actual changes here (outside of vendoring) are very small - I recommend going commit-by-commit