Skip to content

Commit

Permalink
Fix a bug with IE regarding window.scrollX/Y not being supported
Browse files Browse the repository at this point in the history
Signed-off-by: Yannick Gagnon <yannick.gagnon@lemieuxbedard.com>
  • Loading branch information
Yannick Gagnon committed Nov 9, 2016
1 parent d29908d commit 22b1694
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions dist/js/moobile.js
Expand Up @@ -7758,8 +7758,9 @@ Element.defineCustomEvent('tap', {
condition: function(e) {

if (tapValid) {

var element = tapTouch ? document.elementFromPoint(tapTouch.pageX - window.scrollX, tapTouch.pageY - window.scrollY) : null;
var offsetX = window.scrollX === undefined ? window.pageXOffset : window.scrollX,
offsetY = window.scrollY === undefined ? window.pageYOffset : window.scrollY,
element = tapTouch ? document.elementFromPoint(tapTouch.pageX - offsetX, tapTouch.pageY - offsetY) : null;
if (element) {
return this === element || this.contains(element);
}
Expand Down
2 changes: 1 addition & 1 deletion dist/js/moobile.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/event/tap.js
Expand Up @@ -19,8 +19,9 @@ Element.defineCustomEvent('tap', {
condition: function(e) {

if (tapValid) {

var element = tapTouch ? document.elementFromPoint(tapTouch.pageX - window.scrollX, tapTouch.pageY - window.scrollY) : null;
var offsetX = window.scrollX === undefined ? window.pageXOffset : window.scrollX,
offsetY = window.scrollY === undefined ? window.pageYOffset : window.scrollY,
element = tapTouch ? document.elementFromPoint(tapTouch.pageX - offsetX, tapTouch.pageY - offsetY) : null;
if (element) {
return this === element || this.contains(element);
}
Expand Down

0 comments on commit 22b1694

Please sign in to comment.