Merge branch 'MDL-45059-master' of https://github.com/sammarshallou/m…

…oodle
moodle · Apr 18, 2014 · 166dfd5 · 166dfd5
2 parents 2e6b251 + 02dd7ac
commit 166dfd5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/availability/condition/group/classes/frontend.php b/availability/condition/group/classes/frontend.php
@@ -79,9 +79,11 @@ protected function allow_add($course, \cm_info $cm = null,
             \section_info $section = null) {
         global $CFG;
 
-        // Group option can be used on sections, and on modules but only
-        // if groupmembersonly is turned off. (To avoid confusion.)
-        if (!is_null($cm) && $CFG->enablegroupmembersonly) {
+        // If groupmembersonly is turned on, then you can only add group
+        // restrictions on sections (which don't use groupmembersonly) and
+        // not on modules. This is to avoid confusion - otherwise
+        // there would be two ways to add restrictions based on groups.
+        if (is_null($section) && $CFG->enablegroupmembersonly) {
             return false;
         }
 

diff --git a/availability/condition/grouping/classes/frontend.php b/availability/condition/grouping/classes/frontend.php
@@ -74,9 +74,11 @@ protected function allow_add($course, \cm_info $cm = null,
             \section_info $section = null) {
         global $CFG, $DB;
 
-        // Grouping option can be used on sections, and on modules but only
-        // if groupmembersonly is turned off. (To avoid confusion.)
-        if (!is_null($cm) && $CFG->enablegroupmembersonly) {
+        // If groupmembersonly is turned on, then you can only add group
+        // restrictions on sections (which don't use groupmembersonly) and
+        // not on modules. This is to avoid confusion - otherwise
+        // there would be two ways to add restrictions based on groups.
+        if (is_null($section) && $CFG->enablegroupmembersonly) {
             return false;
         }