MDL-60653 Navigation: Fixed loose string comparison.

The previous comparison would sometimes evaluate to true when the navigation key was not a string.
moodle · Dec 12, 2017 · 1ab9160 · 1ab9160
1 parent cb9d984
commit 1ab9160
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/navigationlib.php b/lib/navigationlib.php
@@ -432,7 +432,7 @@ public function find($key, $type) {
     public function build_flat_navigation_list(flat_navigation $nodes, $showdivider = false) {
         if ($this->showinflatnavigation) {
             $indent = 0;
-            if ($this->type == self::TYPE_COURSE || $this->key == self::COURSE_INDEX_PAGE) {
+            if ($this->type == self::TYPE_COURSE || $this->key === self::COURSE_INDEX_PAGE) {
                 $indent = 1;
             }
             $flat = new flat_navigation_node($this, $indent);