Removed some notices, some polishing.

No need to load all users and then remove teachers, can simply load all students.

mod/quiz/lang/en/quiz.php

@@ -116,9 +116,9 @@
 $string['wronguse'] = 'You can not use this page like that';
 
 $string['analysisoptions'] = 'Analysis options';
-$string['attemptselection'] = 'Select which attempts to analyze per user ';
+$string['attemptselection'] = 'Select which attempts to analyze per user: ';
 $string['lowmarkslimit'] = "    Don't analyze if score is less than: ";
 $string['reportanalysis'] = 'Item analysis';
-$string['allattempts'] = 'all attempts';
+$string['allattempts'] = 'All attempts';
 $string['analysistitle'] = 'Item Analysis Table';
 ?>

mod/quiz/locallib.php

@@ -429,7 +429,7 @@ function get_all_responses($question, $state) {
     }
 
     /**
-    * Return the actual response to the question in a given attempt
+    * Return the actual response to the question in a given state
     * for the question
     *
     * @return                 compond object fractiongrade & actual response .

mod/quiz/report/analysis/report.php

@@ -2,7 +2,6 @@
 
 /// Item analysis displays a table of quiz questions and their performance 
 
-    require_once("locallib.php");
     require_once($CFG->libdir.'/tablelib.php');
 
 
@@ -31,10 +30,10 @@ class quiz_report extends quiz_default_report {
     function display($quiz, $cm, $course) {     /// This function just displays the report
 
         global $CFG, $SESSION, $db, $QUIZ_QTYPES;
-        define(QUIZ_ALLATTEMPTS, 0);
-        define(QUIZ_HIGHESTATTEMPT, 1);
-        define(QUIZ_FIRSTATTEMPT, 2);
-        define(QUIZ_LASTATTEMPT, 3);
+        define('QUIZ_ALLATTEMPTS', 0);
+        define('QUIZ_HIGHESTATTEMPT', 1);
+        define('QUIZ_FIRSTATTEMPT', 2);
+        define('QUIZ_LASTATTEMPT', 3);
 
         $strnoquiz = get_string('noquiz','quiz');
         $strnoattempts = get_string('noattempts','quiz');
@@ -54,21 +53,13 @@ function display($quiz, $cm, $course) {     /// This function just displays the
 
     /// Get all users: teachers and students
         if ($currentgroup) {
-            $users = get_group_users($currentgroup);
+            $users = get_group_students($currentgroup);
         }
         else {
-            $users = get_course_users($course->id);
-        }
-
-    /// Remove teachers 
-        $teachers = get_course_teachers($course->id);
-        if(!empty($teachers)) {
-            $keys = array_keys($teachers);
-        }
-        foreach($keys as $key) {
-            unset($users[$key]);
+            $users = get_course_students($course->id);
         }
 
+
         if(empty($users)) {
             print_heading($strnoattempts);
             return true;