MDL-33825 css_optimiser: Fixed bug where !important was being lost fo…

…r advanced background styles
moodle · Jun 19, 2012 · 2395a75 · 2395a75
1 parent f4a9bf6
commit 2395a75
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/csslib.php b/lib/csslib.php
@@ -3845,7 +3845,11 @@ public static function init($value) {
                 } else if ($attachment === self::NULL_VALUE && in_array($bit, $attachments)) {
                     $attachment = $bit;
                 } else if ($bit !== '') {
-                    $return[] = css_style_background_advanced::init($bit);
+                    $advanced = css_style_background_advanced::init($bit);
+                    if ($important) {
+                        $advanced->set_important();
+                    }
+                    $return[] = $advanced;
                 }
             }
         }

diff --git a/lib/tests/csslib_test.php b/lib/tests/csslib_test.php
@@ -213,6 +213,16 @@ public function test_background() {
 
         $css = '#filesskin .yui3-widget-hd{background:#CCC;background:-webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC));background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC);}';
         $this->assertEquals($css, $optimiser->process($css));
+
+        $css = '.userenrolment{background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC) !important;}';
+        $this->assertEquals($css, $optimiser->process($css));
+
+        $css = '.userenrolment{background:#CCC !important;background:-webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC)) !important;background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC) !important;}';
+        $this->assertEquals($css, $optimiser->process($css));
+
+        $cssin = '.userenrolment{background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC) !important;}.userenrolment {background: #CCCCCC!important;background: -webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC))!important;}';
+        $cssout = '.userenrolment{background:#CCC !important;background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC) !important;background:-webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC)) !important;}';
+        $this->assertEquals($cssout, $optimiser->process($cssin));
     }
 
     /**