MDL-48643 Javascript: Create modals hidden, then show, to prevent scroll

Modal dialogs need to be created with visible: false and then call .show() on it to make it visible. This prevents the page from jumping to the top.
moodle · Dec 22, 2014 · 6f0776b · 6f0776b
1 parent 981f06f
commit 6f0776b
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 8 deletions.
diff --git a/course/dndupload.js b/course/dndupload.js
@@ -635,13 +635,14 @@ M.course_dndupload = {
             bodyContent: content,
             width: '350px',
             modal: true,
-            visible: true,
+            visible: false,
             render: true,
             align: {
                 node: null,
                 points: [Y.WidgetPositionAlign.CC, Y.WidgetPositionAlign.CC]
             }
         });
+        panel.show();
         // When the panel is hidden - destroy it and then check for other pending uploads
         panel.after("visibleChange", function(e) {
             if (!panel.get('visible')) {

diff --git a/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes-debug.js b/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes-debug.js
@@ -481,8 +481,10 @@ Y.extend(RESOURCETOOLBOX, TOOLBOX, {
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
             question: confirmstring,
-            modal: true
+            modal: true,
+            visible: false
         });
+        confirm.show();
 
         // If it is confirmed.
         confirm.on('complete-yes', function() {

diff --git a/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes-min.js b/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes-min.js
diff --git a/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes.js b/course/yui/build/moodle-course-toolboxes/moodle-course-toolboxes.js
@@ -481,8 +481,10 @@ Y.extend(RESOURCETOOLBOX, TOOLBOX, {
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
             question: confirmstring,
-            modal: true
+            modal: true,
+            visible: false
         });
+        confirm.show();
 
         // If it is confirmed.
         confirm.on('complete-yes', function() {

diff --git a/course/yui/src/toolboxes/js/resource.js b/course/yui/src/toolboxes/js/resource.js
@@ -277,8 +277,10 @@ Y.extend(RESOURCETOOLBOX, TOOLBOX, {
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
             question: confirmstring,
-            modal: true
+            modal: true,
+            visible: false
         });
+        confirm.show();
 
         // If it is confirmed.
         confirm.on('complete-yes', function() {

diff --git a/enrol/yui/rolemanager/rolemanager.js b/enrol/yui/rolemanager/rolemanager.js
@@ -114,14 +114,16 @@ YUI.add('moodle-enrol-rolemanager', function(Y) {
                 event.detach();
                 var confirmation = {
                     modal:  true,
-                    visible  :  true,
+                    visible  :  false,
                     centered :  true,
                     title    :  M.util.get_string('confirmunassigntitle', 'role'),
                     question :  M.util.get_string('confirmunassign', 'role'),
                     yesLabel :  M.util.get_string('confirmunassignyes', 'role'),
                     noLabel  :  M.util.get_string('confirmunassignno', 'role')
                 };
-                new M.core.confirm(confirmation).on('complete-yes', this.removeRoleCallback, this, user.get(USERID), roleid);
+                new M.core.confirm(confirmation)
+                        .show()
+                        .on('complete-yes', this.removeRoleCallback, this, user.get(USERID), roleid);
             }, this);
             this._loadAssignableRoles();
         },