MDL-45131 grades: Add validation for returned parameters in WS tests

moodle · Apr 16, 2015 · 82fc915 · 82fc915
1 parent 605c421
commit 82fc915
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/grade/report/user/tests/externallib_test.php b/grade/report/user/tests/externallib_test.php
@@ -177,7 +177,8 @@ public function test_view_grade_report() {
         $sink = $this->redirectEvents();
 
         $this->setUser($student1);
-        gradereport_user_external::view_grade_report($course->id);
+        $result = gradereport_user_external::view_grade_report($course->id);
+        $result = external_api::clean_returnvalue(gradereport_user_external::view_grade_report_returns(), $result);
         $events = $sink->get_events();
         $this->assertCount(1, $events);
         $event = reset($events);
@@ -188,7 +189,8 @@ public function test_view_grade_report() {
         $this->assertEquals($USER->id, $event->get_data()['relateduserid']);
 
         $this->setUser($teacher);
-        gradereport_user_external::view_grade_report($course->id, $student1->id);
+        $result = gradereport_user_external::view_grade_report($course->id, $student1->id);
+        $result = external_api::clean_returnvalue(gradereport_user_external::view_grade_report_returns(), $result);
         $events = $sink->get_events();
         $event = reset($events);
         $sink->close();