Skip to content

Commit

Permalink
MDL-37079 Course create/update module. Fix indenting, some comment fo…
Browse files Browse the repository at this point in the history 
…rmatting and whitespace.
  • Loading branch information
Damyon Wiese committed Mar 19, 2013
1 parent 8fe55f6 commit 8f2913b
Showing 1 changed file with 39 additions and 39 deletions.
78 changes: 39 additions & 39 deletions course/modlib.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
print_error('moduledisable', '', '', $moduleinfo->modulename);
}

// first add course_module record because we need the context
// First add course_module record because we need the context.
$newcm = new stdClass();
$newcm->course = $course->id;
$newcm->module = $moduleinfo->module;
Expand Down Expand Up @@ -292,7 +292,7 @@ function edit_module_post_actions($moduleinfo, $course, $eventname) {
rebuild_course_cache($course->id);
grade_regrade_final_grades($course->id);
require_once($CFG->libdir.'/plagiarismlib.php');
plagiarism_save_form_elements($moduleinfo); //save plagiarism settings
plagiarism_save_form_elements($moduleinfo);

return $moduleinfo;
}
Expand All @@ -318,8 +318,8 @@ function set_moduleinfo_defaults($moduleinfo) {
$moduleinfo->instance = $cm->instance;
$moduleinfo->coursemodule = $cm->id;
}

$moduleinfo->modulename = clean_param($moduleinfo->modulename, PARAM_PLUGIN); // For safety
// For safety.
$moduleinfo->modulename = clean_param($moduleinfo->modulename, PARAM_PLUGIN);

if (!isset($moduleinfo->groupingid)) {
$moduleinfo->groupingid = 0;
Expand Down Expand Up @@ -453,49 +453,49 @@ function update_moduleinfo($cm, $moduleinfo, $course, $mform = null) {
$cm->showdescription = 0;
}

$DB->update_record('course_modules', $cm);
$DB->update_record('course_modules', $cm);

$modcontext = context_module::instance($moduleinfo->coursemodule);
$modcontext = context_module::instance($moduleinfo->coursemodule);

// update embedded links and save files.
if (plugin_supports('mod', $moduleinfo->modulename, FEATURE_MOD_INTRO, true)) {
$moduleinfo->intro = file_save_draft_area_files($moduleinfo->introeditor['itemid'], $modcontext->id,
'mod_'.$moduleinfo->modulename, 'intro', 0,
array('subdirs'=>true), $moduleinfo->introeditor['text']);
$moduleinfo->introformat = $moduleinfo->introeditor['format'];
unset($moduleinfo->introeditor);
}
$updateinstancefunction = $moduleinfo->modulename."_update_instance";
if (!$updateinstancefunction($moduleinfo, $mform)) {
print_error('cannotupdatemod', '', course_get_url($course, $cw->section), $moduleinfo->modulename);
}
// Update embedded links and save files.
if (plugin_supports('mod', $moduleinfo->modulename, FEATURE_MOD_INTRO, true)) {
$moduleinfo->intro = file_save_draft_area_files($moduleinfo->introeditor['itemid'], $modcontext->id,
'mod_'.$moduleinfo->modulename, 'intro', 0,
array('subdirs'=>true), $moduleinfo->introeditor['text']);
$moduleinfo->introformat = $moduleinfo->introeditor['format'];
unset($moduleinfo->introeditor);
}
$updateinstancefunction = $moduleinfo->modulename."_update_instance";
if (!$updateinstancefunction($moduleinfo, $mform)) {
print_error('cannotupdatemod', '', course_get_url($course, $cw->section), $moduleinfo->modulename);
}

// Make sure visibility is set correctly (in particular in calendar).
if (has_capability('moodle/course:activityvisibility', $modcontext)) {
set_coursemodule_visible($moduleinfo->coursemodule, $moduleinfo->visible);
}
// Make sure visibility is set correctly (in particular in calendar).
if (has_capability('moodle/course:activityvisibility', $modcontext)) {
set_coursemodule_visible($moduleinfo->coursemodule, $moduleinfo->visible);
}

if (isset($moduleinfo->cmidnumber)) { // Label.
// Set cm idnumber - uniqueness is already verified by form validation.
set_coursemodule_idnumber($moduleinfo->coursemodule, $moduleinfo->cmidnumber);
}
if (isset($moduleinfo->cmidnumber)) { // Label.
// Set cm idnumber - uniqueness is already verified by form validation.
set_coursemodule_idnumber($moduleinfo->coursemodule, $moduleinfo->cmidnumber);
}

// Now that module is fully updated, also update completion data if required.
// (this will wipe all user completion data and recalculate it)
if ($completion->is_enabled() && !empty($moduleinfo->completionunlocked)) {
$completion->reset_all_state($cm);
}
// Now that module is fully updated, also update completion data if required.
// (this will wipe all user completion data and recalculate it)
if ($completion->is_enabled() && !empty($moduleinfo->completionunlocked)) {
$completion->reset_all_state($cm);
}

add_to_log($course->id, "course", "update mod",
"../mod/$moduleinfo->modulename/view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->modulename $moduleinfo->instance");
add_to_log($course->id, $moduleinfo->modulename, "update",
"view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->instance", $moduleinfo->coursemodule);
add_to_log($course->id, "course", "update mod",
"../mod/$moduleinfo->modulename/view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->modulename $moduleinfo->instance");
add_to_log($course->id, $moduleinfo->modulename, "update",
"view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->instance", $moduleinfo->coursemodule);

$moduleinfo = edit_module_post_actions($moduleinfo, $course, 'mod_updated');
$moduleinfo = edit_module_post_actions($moduleinfo, $course, 'mod_updated');

return array($cm, $moduleinfo);
return array($cm, $moduleinfo);
}

/**
Expand Down

0 comments on commit 8f2913b

Please sign in to comment.