MDL-36506 mod_book: Skip legacy files migration if missing a CM record

moodle · Mar 24, 2015 · 9ad24a0 · 9ad24a0
1 parent 7e39143
commit 9ad24a0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/mod/book/db/upgradelib.php b/mod/book/db/upgradelib.php
@@ -108,12 +108,16 @@ function mod_book_migrate_moddata_dir_to_legacy($book, $context, $path) {
  * @return void
  */
 function mod_book_migrate_all_areas() {
-    global $DB;
+    global $DB, $OUTPUT;
 
     $rsbooks = $DB->get_recordset('book');
     foreach($rsbooks as $book) {
         upgrade_set_timeout(360); // set up timeout, may also abort execution
         $cm = get_coursemodule_from_instance('book', $book->id);
+        if (empty($cm) || empty($cm->id)) {
+             echo $OUTPUT->notification("Course module not found, skipping: {$book->name}");
+             continue;
+        }
         $context = context_module::instance($cm->id);
         mod_book_migrate_area($book, 'intro', 'book', $book->course, $context, 'mod_book', 'intro', 0);