MDL-22441 Invalid SQL (must not have ; at the end )

moodle · May 11, 2010 · 9e45963 · 9e45963
1 parent e0c9ba5
commit 9e45963
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/question/type/calculated/questiontype.php b/question/type/calculated/questiontype.php
@@ -250,7 +250,7 @@ function import_datasets($question){
                         "type = '1'
                         AND name = ?
                         AND category = ?
-                        ORDER BY id DESC;", array($dataset->name, $question->category)
+                        ORDER BY id DESC ", array($dataset->name, $question->category)
                        )) { // so there is at least one
                     $sharedatasetdef = array_shift($sharedatasetdefs);
                     if ( $sharedatasetdef->options ==  $datasetdef->options ){// identical so use it
@@ -672,7 +672,7 @@ function delete_question($questionid) {
                 if (!$DB->get_records_select(
                         'question_datasets',
                         "question != ?
-                        AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){
+                        AND datasetdefinition = ? ", array($questionid, $dataset->datasetdefinition))){
                     $DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
                     $DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
                 }