Skip to content

Commit

Permalink
MDL-61321 mod_feedback: Return all the items responses
Browse files Browse the repository at this point in the history
The WS should receive all the item responses for all the attempts.
  • Loading branch information
jleyva committed Mar 20, 2018
1 parent 263e505 commit b195c7d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mod/feedback/classes/responses_table.php
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ protected function add_all_values_to_output() {
$tableheaders = $this->headers;

$items = $this->feedbackstructure->get_items(true);
if (!$this->is_downloading()) {
if (!$this->is_downloading() && !$this->buildforexternal) {
// In preview mode do not show all columns or the page becomes unreadable.
// The information message will be displayed to the teacher that the rest of the data can be viewed when downloading.
$items = array_slice($items, 0, self::PREVIEWCOLUMNSLIMIT, true);
Expand Down Expand Up @@ -617,8 +617,8 @@ protected function add_data_for_external($row) {
*/
public function export_external_structure($page = 0, $perpage = 0) {

$this->add_all_values_to_output();
$this->buildforexternal = true;
$this->add_all_values_to_output();
// Set-up.
$this->setup();
// Override values, if needed.
Expand Down

0 comments on commit b195c7d

Please sign in to comment.