MDL-64640 feedback: Fix target link on deletion

moodle · Jan 27, 2019 · bc3ba91 · bc3ba91
1 parent 5280442
commit bc3ba91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/mod/feedback/amd/build/edit.min.js b/mod/feedback/amd/build/edit.min.js
diff --git a/mod/feedback/amd/src/edit.js b/mod/feedback/amd/src/edit.js
@@ -25,6 +25,7 @@ function($, ajax, str, notification) {
     var manager = {
         deleteItem: function(e) {
             e.preventDefault();
+            var targetUrl = $(e.currentTarget).attr('href');
 
             str.get_strings([
                 {
@@ -43,11 +44,15 @@ function($, ajax, str, notification) {
                     key:        'no',
                     component:  'moodle'
                 }
-            ]).done(function(s) {
-                notification.confirm(s[0], s[1], s[2], s[3], $.proxy(function() {
-                    window.location = $(this).attr('href');
-                }, e.currentTarget));
-            });
+            ])
+            .then(function(s) {
+                notification.confirm(s[0], s[1], s[2], s[3], function() {
+                    window.location = targetUrl;
+                });
+
+                return;
+            })
+            .catch();
         },
 
         setup: function() {