mirrored from git://git.moodle.org/moodle.git
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDL-67636 gradebook: Prevent exposing hidden grade in locked category
- Loading branch information
John Yao
committed
Nov 19, 2020
1 parent
f86b5e3
commit bf17d50
Showing
4 changed files
with
199 additions
and
4 deletions.
There are no files selected for viewing
92 changes: 92 additions & 0 deletions
92
grade/tests/behat/grade_hidden_items_locked_category.feature
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
@core @core_grades | ||
Feature: Hidden grade items should be hidden when grade category is locked, but should be visible in overridden category | ||
In order to verify existing grades items display as expected | ||
As an teacher | ||
I need to modify grade items and grade categories | ||
I need to ensure existing grades display in an expected manner | ||
|
||
Background: | ||
Given the following "courses" exist: | ||
| fullname | shortname | category | groupmode | | ||
| Course 1 | C1 | 0 | 1 | | ||
And the following "users" exist: | ||
| username | firstname | lastname | email | idnumber | | ||
| teacher1 | Teacher | 1 | teacher1@example.com | t1 | | ||
| student1 | Student | 1 | student1@example.com | s1 | | ||
And the following "course enrolments" exist: | ||
| user | course | role | | ||
| teacher1 | C1 | editingteacher | | ||
| student1 | C1 | student | | ||
And I log in as "admin" | ||
And I am on "Course 1" course homepage | ||
And I navigate to "Setup > Gradebook setup" in the course gradebook | ||
And I press "Add category" | ||
And I set the following fields to these values: | ||
| Category name | Test locked category | | ||
And I press "Save changes" | ||
And I press "Add grade item" | ||
And I set the following fields to these values: | ||
| Item name | Hidden item | | ||
| Hidden | 1 | | ||
| Grade category | Test locked category | | ||
And I press "Save changes" | ||
And I log out | ||
And I log in as "teacher1" | ||
And I am on "Course 1" course homepage | ||
And I navigate to "View > Grader report" in the course gradebook | ||
And I turn editing mode on | ||
And I give the grade "50.00" to the user "Student 1" for the grade item "Hidden item" | ||
And I press "Save changes" | ||
And I navigate to "Setup > Gradebook setup" in the course gradebook | ||
And I set the following settings for grade item "Test locked category": | ||
| Locked | 1 | | ||
And I press "Save changes" | ||
And I log out | ||
|
||
Scenario: Hidden grade items in locked category is hidden for teacher | ||
Given I log in as "teacher1" | ||
And I am on "Course 1" course homepage | ||
And I navigate to "View > User report" in the course gradebook | ||
And I select "Myself" from the "View report as" singleselect | ||
When I select "Student 1" from the "Select all or one user" singleselect | ||
Then the following should exist in the "user-grade" table: | ||
| Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total | | ||
| Test locked category total | 100.00 % | 50.00 | 0–100 | 50.00 % | - | | ||
| Course total | - | 50.00 | 0–100 | 50.00 % | - | | ||
|
||
Scenario: Hidden grade items in locked category is hidden for student | ||
Given I log in as "student1" | ||
And I am on "Course 1" course homepage | ||
When I navigate to "User report" in the course gradebook | ||
Then the following should exist in the "user-grade" table: | ||
| Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total | | ||
| Test locked category total | 100.00 % | - | 0–100 | - | - | | ||
| Course total | - | - | 0–100 | - | - | | ||
And I should not see "Hidden item" | ||
|
||
Scenario: Hidden grade items in overridden category should show | ||
Given I log in as "teacher1" | ||
And I am on "Course 1" course homepage | ||
And I navigate to "Setup > Gradebook setup" in the course gradebook | ||
And I press "Add category" | ||
And I set the following fields to these values: | ||
| Category name | Test overridden category B| | ||
And I press "Save changes" | ||
And I press "Add grade item" | ||
And I set the following fields to these values: | ||
| Item name | Cat b item | | ||
| Grade category | Test overridden category B | | ||
And I press "Save changes" | ||
When I navigate to "View > Grader report" in the course gradebook | ||
And I turn editing mode on | ||
And I give the grade "50.00" to the user "Student 1" for the grade item "Test overridden category B total" | ||
And I press "Save changes" | ||
And I log out | ||
And I log in as "student1" | ||
And I am on "Course 1" course homepage | ||
And I navigate to "User report" in the course gradebook | ||
Then the following should exist in the "user-grade" table: | ||
| Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total | | ||
| Test locked category total | 50.00 % | - | 0–100 | - | - | | ||
| Test overridden category B total | 50.00 % | 50.00 | 0–100 | 50.00 % | - | | ||
| Course total | - | - | 0–200 | - | - | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters