MDL-69113 assign: save grader app workflow/marker filters correctly

moodle · Jun 25, 2020 · c31a321 · c31a321
1 parent 1ab9522
commit c31a321
Show file tree

Hide file tree

Showing 4 changed files with 115 additions and 4 deletions.
diff --git a/mod/assign/amd/build/grading_navigation.min.js b/mod/assign/amd/build/grading_navigation.min.js
diff --git a/mod/assign/amd/build/grading_navigation.min.js.map b/mod/assign/amd/build/grading_navigation.min.js.map
diff --git a/mod/assign/amd/src/grading_navigation.js b/mod/assign/amd/src/grading_navigation.js
@@ -229,10 +229,13 @@ define(['jquery', 'core/notification', 'core/str', 'core/form-autocomplete',
         // There are 3 types of filter right now.
         var filterPanel = this._region.find('[data-region="configure-filters"]');
         var filters = filterPanel.find('select');
+        var preferenceNames = [];
 
         this._filters = [];
         filters.each(function(idx, ele) {
-            this._filters.push($(ele).val());
+            var element = $(ele);
+            this._filters.push(element.val());
+            preferenceNames.push('assign_' + element.prop('name'));
         }.bind(this));
 
         // Update the active filter string.
@@ -250,7 +253,6 @@ define(['jquery', 'core/notification', 'core/str', 'core/form-autocomplete',
 
         var select = this._region.find('[data-action=change-user]');
         var currentUserID = select.data('currentuserid');
-        var preferenceNames = ['assign_filter', 'assign_workflowfilter', 'assign_markerfilter'];
         this._updateFilterPreferences(currentUserID, this._filters, preferenceNames).done(function() {
             // Reload the list of users to apply the new filters.
             if (!this._loadAllUsers()) {