MDL-13766: refactor all repository_instance() => repository_get_insta…

…nce()

admin/repository.php

@@ -37,7 +37,7 @@
 
 if (!empty($edit) || !empty($new)) {
     if (!empty($edit)) {
-        $instance = repository_instance($edit);
+        $instance = repository_get_instance($edit);
         $configs  = $instance->get_option_names();
         $plugin = $instance->type;
         $typeid = $instance->typeid;
@@ -90,12 +90,12 @@
     if (!confirm_sesskey()) {
         print_error('confirmsesskeybad', '', $baseurl);
     }
-    $instance = repository_instance($hide);
+    $instance = repository_get_instance($hide);
     $instance->hide();
     $return = true;
 } else if (!empty($delete)) {
     admin_externalpage_print_header();
-    $instance = repository_instance($delete);
+    $instance = repository_get_instance($delete);
     if ($sure) {
         if (!confirm_sesskey()) {
             print_error('confirmsesskeybad', '', $baseurl);

repository/boxnet/settings.php

@@ -43,7 +43,7 @@ public function definition() {
 print_header("$course->fullname: $fullname: $strplugin", $course->fullname,
              $navigation, "", "", true, " ", navmenu($course));
 
-$instance = repository_instance($repositoryid);
+$instance = repository_get_instance($repositoryid);
 $mform = new boxnet_user_form('', array('repositoryid' => $repositoryid, 'userid' => $user->id));
 $box = new repository_boxnet();
 if ($data = data_submitted()){

repository/lib.php

@@ -217,7 +217,7 @@ final public static function create($type, $userid, $context, $params) {
             }
             if (!empty($id)) {
                 unset($options['name']);
-                $instance = repository_instance($id);
+                $instance = repository_get_instance($id);
                 $instance->set_option($options);
                 return $id;
             } else {
@@ -485,7 +485,7 @@ function repository_instances($context, $userid = null, $visible = true){
  * @param int repository id
  * @return object repository instance
  */
-function repository_instance($id){
+function repository_get_instance($id){
     global $DB, $CFG;
     $sql = 'SELECT i.*, r.type AS repositorytype, r.visible FROM {repository} r, {repository_instances} i WHERE ';
     $sql .= 'i.typeid = r.id AND ';

repository/ws.php

@@ -26,7 +26,7 @@
 $ctx_id  = optional_param('ctx_id', SITEID, PARAM_INT);
 $userid  = $USER->id;
 
-if(!$repository = repository_instance($repo_id))
+if(!$repository = repository_get_instance($repo_id))
 {
     $err = new stdclass;
     $err->e = get_string('invalidrepositoryid', 'repository');