New developmental setting to force UTF for the whole server

Plus, some optimisation on the way encoding is stored (in the session).
moodle · Apr 27, 2004 · cec0a0f · cec0a0f
1 parent 37aaf07
commit cec0a0f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/config-dist.php b/config-dist.php
@@ -148,6 +148,11 @@
 //
 // Setting this to true will enable admins to edit any post at any time
 //      $CFG->admineditalways = true;
+//
+// This setting will put Moodle in Unicode mode.  It's very new and 
+// most likely doesn't work yet.   THIS IS FOR DEVELOPERS ONLY, IT IS
+// NOT RECOMMENDED FOR PRODUCTION SITES
+//      $CFG->unicode = true;
 
 
 

diff --git a/lib/setup.php b/lib/setup.php
@@ -219,6 +219,7 @@ class object {};
 
     if (isset($_GET['lang'])) {
         $SESSION->lang = $lang;
+        $SESSION->encoding = get_string('thischarset');
     }
     if (empty($CFG->lang)) {
         $CFG->lang = "en";

diff --git a/lib/weblib.php b/lib/weblib.php
@@ -375,7 +375,7 @@ function choose_from_menu ($options, $name, $selected="", $nothing="choose", $sc
     $output = "<select name=\"$name\" $javascript>\n";
     if ($nothing) {
         $output .= "   <option value=\"$nothingvalue\"\n";
-        if ($nothingvalue == $selected) {
+        if ($nothingvalue === $selected) {
             $output .= " selected=\"true\"";
         }
         $output .= ">$nothing</option>\n";
@@ -931,13 +931,15 @@ function print_header ($title="", $heading="", $navigation="", $focus="", $meta=
     // Add a stylesheet for the HTML editor
     $meta = "<style type=\"text/css\">@import url($CFG->wwwroot/lib/editor/htmlarea.css);</style>\n$meta\n";
 
-    // Specify character set ... default is iso-8859-1 but some languages might need something else
-    // Could be optimised by carrying the charset variable around in $USER
-    if (current_language() == "en") {
-        $meta = "<meta http-equiv=\"content-type\" content=\"text/html; charset=iso-8859-1\" />\n$meta\n";
+    // Character set could be optimised by carrying the charset variable around in $USER
+    if (!empty($CFG->unicode)) {
+        $encoding = "utf-8";
+    } else if (!empty($SESSION->encoding)) {
+        $encoding = $SESSION->encoding;
     } else {
-        $meta = "<meta http-equiv=\"content-type\" content=\"text/html; charset=".get_string("thischarset")."\" />\n$meta\n";
+        $encoding = get_string("thischarset");
     }
+    $meta = "<meta http-equiv=\"content-type\" content=\"text/html; charset=$encoding\" />\n$meta\n";
 
     if ( get_string("thisdirection") == "rtl" ) {
         $direction = " dir=\"rtl\"";