Skip to content

Commit

Permalink
MDL-60567 competencies: list_competencies wrong type
Browse files Browse the repository at this point in the history
"validate_params" returns arrays in external functions.
  • Loading branch information
Damyon Wiese committed Oct 27, 2017
1 parent bcca46d commit df4dd00
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions competency/classes/external.php
Original file line number Diff line number Diff line change
Expand Up @@ -841,10 +841,10 @@ public static function list_competencies($filters, $sort, $order, $skip, $limit)
$validcolumns = array('id', 'shortname', 'description', 'sortorder', 'idnumber',
'parentid', 'competencyframeworkid');
foreach ($params['filters'] as $filter) {
if (!in_array($filter->column, $validcolumns)) {
if (!in_array($filter['column'], $validcolumns)) {
throw new invalid_parameter_exception('Filter column was invalid');
}
$safefilters[$filter->column] = $filter->value;
$safefilters[$filter['column']] = $filter['value'];
}

$context = null;
Expand Down

0 comments on commit df4dd00

Please sign in to comment.