Skip to content

Commit

Permalink
MDL-81351 lang: Use the fixed strings in the tests, too
Browse files Browse the repository at this point in the history
  • Loading branch information
mudrd8mz committed Mar 28, 2024
1 parent dccc91f commit eecbf7b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion admin/tool/uploadcourse/tests/behat/update.feature
Expand Up @@ -118,7 +118,7 @@ Feature: An admin can update courses using a CSV file
# Course C01 is in "our" category but can not be moved to Cat 2 because current user can not manage it.
Then I should see "No permission to upload courses in category: Cat 2" in the "C01" "table_row"
# Course C02 can not be updated (no capability in "Cat 2" context).
And I should see "Course with this shortname exists and you don't have permission to use upload course tool to update it" in the "C02" "table_row"
And I should see "A course with this short name exists but you don't have permission to use the upload courses functionality to update it." in the "C02" "table_row"
# Course with short name "C05" does not exist.
And I should see "The course does not exist and creating course is not allowed" in the "C05" "table_row"
And I click on "Upload courses" "button"
Expand Down
4 changes: 2 additions & 2 deletions admin/tool/uploaduser/tests/upload_users_test.php
Expand Up @@ -202,8 +202,8 @@ public function test_user_upload_user_validate(): void {

// We should get the debugging from the user class itself, as well as warning in the output regarding the same.
$this->assertDebuggingCalled('The property \'country\' has invalid data and has been cleaned.');
$this->assertStringContainsString('Invalid data detected for user \'student1\' (country), ' .
'which has been automatically cleaned.', $output);
$this->assertStringContainsString('Incorrect data (country) found for user student1. ' .
'This data has been corrected or deleted.', $output);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion enrol/self/tests/self_test.php
Expand Up @@ -293,7 +293,7 @@ public function test_longtimenosee_notifications(
$this->assertCount($numnotifications, $messages);
if ($numnotifications && ($customint2 > 0)) {
$this->assertEquals($user3->id, $messages[0]->useridto);
$this->assertStringContainsString('you have not visited', $messages[0]->fullmessagehtml);
$this->assertStringContainsString('you have not accessed', $messages[0]->fullmessagehtml);
}

// Make sure that notifications are not repeated.
Expand Down
Expand Up @@ -43,6 +43,6 @@ Feature: I can create a bigbluebuttonbn instance with default server

Examples:
| user | shouldseemessage | messageexist |
| user1 | The use of default server credentials will soon expire.| should not see |
| teacher1 | The use of default server credentials will soon expire.| should see |
| admin | Default BigBlueButton plugin credentials will soon expire.| should see |
| user1 | The BigBlueButton server credentials will soon expire. | should not see |
| teacher1 | The BigBlueButton server credentials will soon expire. | should see |
| admin | The BigBlueButton server credentials will soon expire. | should see |
6 changes: 3 additions & 3 deletions mod/scorm/tests/behat/scorm_activity_completion.feature
Expand Up @@ -139,13 +139,13 @@ Feature: View activity completion in the SCORM activity
And I expand all fieldsets
When I set the field "completionscorerequired" to "0"
And I click on "Save and display" "button"
Then I should see "Minimum score must be greater than 0"
Then I should see "Minimum score must be greater than 0."
And "Enter" "button" should not exist
And I set the field "completionscorerequired" to "-1"
And I click on "Save and display" "button"
And I should see "Minimum score must be greater than 0"
And I should see "Minimum score must be greater than 0."
And "Enter" "button" should not exist
And I set the field "completionscorerequired" to "5"
And I click on "Save and display" "button"
And I should not see "Minimum score must be greater than 0"
And I should not see "Minimum score must be greater than 0."
And "Enter" "button" should exist

0 comments on commit eecbf7b

Please sign in to comment.