MDL-42526 mod_assignment : fix record insert with assigment.id 0

moodle · May 22, 2014 · fdb6811 · fdb6811
1 parent a929fd5
commit fdb6811
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
@@ -6781,14 +6781,13 @@ public static function allocate_unique_ids($assignid) {
         // Shuffle the users.
         shuffle($users);
 
-        $record = new stdClass();
-        $record->assignment = $assignid;
         foreach ($users as $user) {
             $record = $DB->get_record('assign_user_mapping',
                                       array('assignment'=>$assignid, 'userid'=>$user->id),
                                      'id');
             if (!$record) {
                 $record = new stdClass();
+                $record->assignment = $assignid;
                 $record->userid = $user->id;
                 $DB->insert_record('assign_user_mapping', $record);
             }