Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The help text for SSID uses a wrong number of bytes #53

Closed
ralf-krause opened this issue Aug 27, 2018 · 3 comments
Closed

The help text for SSID uses a wrong number of bytes #53

ralf-krause opened this issue Aug 27, 2018 · 3 comments
Assignees
Labels
Status: tests passed Feature or fix is successfully tested Type: bug Something isn't working
Milestone

Comments

@ralf-krause
Copy link

ralf-krause commented Aug 27, 2018

Help text for SSID is not correct: "The name of the Wi-Fi network (SSID) of the MoodleBox. The string must be a minimum of 8 bytes and a maximum of 32 bytes."

Also in the code comment this fact is not considered. The code allows from 1 to 32 bytes and this is correct.

# We want to check that it is valid, and between 8 and 32 bytes.`
[[ $NEWSSID =~ ^([0-9a-fA-F]{2}){1,32}$ ]] || NEWSSID="4d6f6f646c65426f78" # "MoodleBox"
@martignoni martignoni self-assigned this Aug 27, 2018
@martignoni martignoni added the Type: bug Something isn't working label Aug 27, 2018
@martignoni martignoni added this to the 2.0.0 milestone Aug 27, 2018
@ralf-krause
Copy link
Author

I think that the help text could be something like this-
The name of the Wi-Fi network (SSID) of the Moodlebox can be from 1 to 32 bytes long. Please remember that some characters are using more than 1 bytes, e.g. Emoji.

@martignoni
Copy link
Member

Thanks for the suggestion. I'll complete the string along your line.

martignoni added a commit that referenced this issue Aug 27, 2018
@martignoni martignoni modified the milestones: 2.0.0, 1.12.1 Aug 27, 2018
martignoni added a commit that referenced this issue Aug 27, 2018
@martignoni martignoni added Status: test started Test started for feature or fix Status: tests passed Feature or fix is successfully tested and removed Status: test started Test started for feature or fix labels Aug 27, 2018
@martignoni
Copy link
Member

Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: tests passed Feature or fix is successfully tested Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants