Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database collation should be utf8mb4_unicode_ci #323

Closed
ralf-krause opened this issue Feb 22, 2024 · 2 comments · Fixed by #327
Closed

Database collation should be utf8mb4_unicode_ci #323

ralf-krause opened this issue Feb 22, 2024 · 2 comments · Fixed by #327
Assignees
Labels
Status: test passed Feature or fix is successfully tested Type: bug Something isn't working
Milestone

Comments

@ralf-krause
Copy link

Describe the bug

The MoodleBox database collation is utf8mb4_general_ci and should be utf8mb4_unicode_ci instead.
Please look at https://docs.moodle.org/403/en/MySQL_full_unicode_support

To Reproduce

You can see the database collations when you get http://moodlebox.home/adminer.php
And you should see the database collation in the Moodle config.php

Expected behavior

I think your setting with the collation utf8mb4_general_ci should be no problem as long as nobody gets a collation mix in the database. I heart about the mix problem in https://moodle.org/mod/forum/discuss.php?d=455362 . I can’t say if the installation of a plugin will be able to add database tables with a different collation.

Additional context

  • Raspberry Pi 4B
  • MoodleBox 4.6.0
  • MoodleBox plugin 2.17.4
  • Moodle 4.3.3+ (20240215)

Screenshots

No screenshot

@ralf-krause ralf-krause added the Type: bug Something isn't working label Feb 22, 2024
@martignoni
Copy link
Member

martignoni commented Feb 22, 2024

Did you experience any problems with current utf8mb4_general_ci collation? (other than MoodleHQ recommendation)

I just verified the whole DB has the same utf8mb4_general_ci collation, so the mixed collation shouldn't be an issue.

Anyway, following upstream recommendations is always a good idea, so I'll fix this.

@martignoni martignoni self-assigned this Feb 22, 2024
@martignoni martignoni added this to the 4.7.0 milestone Feb 22, 2024
@ralf-krause
Copy link
Author

ralf-krause commented Feb 22, 2024

As I wrote utf8mb4_general_ci should be no problem as long as nobody gets a collation mix in the database. I can‘t say from which reason the database get‘s a collation mix … could it be a plugin installation? Could it be a Moodle course restored from a platform with a different collation?

@martignoni martignoni added Type: bug Something isn't working Status: work started Work started on this issue and removed Type: bug Something isn't working labels Feb 22, 2024
@martignoni martignoni linked a pull request Feb 23, 2024 that will close this issue
@martignoni martignoni added Status: test started Test of feature or fix in progress Status: test passed Feature or fix is successfully tested and removed Status: test started Test of feature or fix in progress Status: work started Work started on this issue labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: test passed Feature or fix is successfully tested Type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants