php74: Fix a couple of remaining curly-bracket uses

[stronk7]

These escaped #65 and just noticed them today when executing
the bundled pear/PHP/scripts/phpcs binary (not reproducible
from web or tests).

Also fix an unrelated typo in CHANGES.md

Finally, have added some important changes to travis, aiming for simplicity (include jobs instead of matrix + excludes), better nodejs handling...

[stronk7]

Can be checked with:

ag '(\$[0-9a-zA-Z_]+|\))(\[['\''"\w$]+\])?{[^\n=}]+}' --php | sort | uniq

(note that there are 2 cases within PHPCompatibility, but they are literals there, not code)

Or running, with php74:

local/codechecker/pear/PHP/scripts/phpcs --standard=local/codechecker/moodle mod/label/classes

Without the patch there are some PHP notices for those lines. With the patch it runs ok.

[andrewnicols]

We shouldn't be specifying a version here.

All supported versions of Moodle since 3.5 have the nvmrc, and we do something like:

 if [ -f .nvmrc ]; then
    nvm install
    nvm use
else
    // Old LTS before we had an nvmrc is lts/carbon
    nvm install lts/carbon
fi

[stronk7]

We shouldn't be specifying a version here.

All supported versions of Moodle since 3.5 have the nvmrc, and we do something like:

Yeah, I'm well aware and, in fact, that was my primary attempt, to leave 35_STABLE and up just using nvm use && nvm_install. But it didn't work, I did a good number of attempts against travis, but I'm afraid:

1. nvm is installed BEFORE core codebase is available thanks to moodle-plugin-ci install. So, at all effects, it's not .nvmrc aware.
2. So, then I tried moving the nvm stuff to after moodle-plugin-ci install but it also failed (because moodle-plugin-ci install needs a node/npm available).
3. So, lalala, only solution was to, explicitly, set the default (14).

To make this work as expected, once again, changes to moodle-plugin-ci are required. :-(

Ciao :-)

[stronk7]

Ping!

[andrewnicols]

Sorry - this had dropped off my radar. Thanks for the detailed explanation.

[stronk7]

Thanks!