Remove ^ and $ markers at the beginning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! :) Do you have any test cases in mind that we could add to the test suite? |
|
Actually, this bug fails the existing tests. If you run tests for multiple times, sometimes some of them will fail. After I applied this change, tests stopped to fail (actually, they are still flucky, but due to the different reason 😅). Do you want me to add test cases which previously failed for each time? ;-) |
That'd be awesome 👍 |
The current approach when characters are removed from the result suffers from the issue that sometimes symbols are the valid parts of result. Therefore, after we remove them, the produced string no longer matches the original regular expression. Fixed that by removing markers _before_ regular expression generation.
zvirja
force-pushed
the
fix-sporadic-failure-due-to-post-trim
branch
from
78651d5
to
3b84b51
Compare
|
Added ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach when characters are removed from the result suffers from the issue that sometimes symbols are the valid parts of result. Therefore, after we remove them, the produced string no longer matches the expected regular expression.
Fixed that by removing markers before regular expression generation.