Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page on Custom XCM Messages #560

Merged
merged 15 commits into from
Mar 24, 2023
Merged

Add a page on Custom XCM Messages #560

merged 15 commits into from
Mar 24, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Feb 28, 2023

Description

This PR adds a new page on Custom XCM Messages and highlights the ability to execute a custom XCM message locally on Moonbase Alpha.

Decided to have a standalone page for Custom XCM messages that shows users how to interact directly with the Polkadot XCM Pallet and the XCM Utilities Precompile. Was initially going to do a layout similar to the X-Tokens page, but instead decided to keep the XCM Utilities Precompile page in tact as there is more functionality to it that can applied in other situations aside from creating custom XCM messages.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images.

After Translation Requirements

  • No additional PRs are required after the translations are done

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - As I was reading I thought I was going to see a section to be able to send XCM messages as well 😬 What do you think?

builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
builders/interoperability/xcm/custom-xcm-messages.md Outdated Show resolved Hide resolved
@eshaben eshaben requested a review from albertov19 March 20, 2023 14:02
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a couple of commits, please check them before merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants