Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supra Docs #873

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Supra Docs #873

merged 8 commits into from
Mar 8, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Feb 22, 2024

Description

This PR updates the Supra docs to apply Moonbeam standards and showcases a complete example of interacting with Supra.

The termynal snippet has text that flows outside of the window, so I created a companion PR for mkdocs that updates the styling so that it wraps to the next line: papermoonio/moonbeam-mkdocs#172

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • No additional PRs are required after the translations are done

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is challenging to go through, but either way, it looks OK from my perspective.

Left some feedback

builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
builders/integrations/oracles/supra.md Outdated Show resolved Hide resolved
themacexpert
themacexpert previously approved these changes Feb 23, 2024
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

{{ networks.moonbeam.supra.pull_oracle }}
```

=== "Moonbase Alpha"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the contracts are verified for Moonbeam but not for Moonbase Alpha. Is it possible for the Supra team to verify these for Moonbase Alpha as well?

builders/integrations/oracles/supra.md Show resolved Hide resolved
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
@eshaben
Copy link
Contributor Author

eshaben commented Mar 5, 2024

Moved the step-by-step instructions to a tutorial, because it's quite long. So I opted to try and leave the Supra page in the Builders section as more of a quick reference, here's what you need to know, and then link to the tutorial for a deep dive.

@eshaben eshaben added the A0 - New Content Pull request contains new content pages label Mar 5, 2024
@eshaben eshaben requested a review from albertov19 March 5, 2024 15:34
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent idea on splitting the things into separate pages!

I also love the new scoped code snippet thingy 🤓

@eshaben eshaben merged commit c80c433 into master Mar 8, 2024
1 check passed
@eshaben eshaben deleted the eshaben/supra branch March 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants