-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supra Docs #873
Supra Docs #873
Conversation
added supra oracle info to moonbeam docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is challenging to go through, but either way, it looks OK from my perspective.
Left some feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
{{ networks.moonbeam.supra.pull_oracle }} | ||
``` | ||
|
||
=== "Moonbase Alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the contracts are verified for Moonbeam but not for Moonbase Alpha. Is it possible for the Supra team to verify these for Moonbase Alpha as well?
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
Moved the step-by-step instructions to a tutorial, because it's quite long. So I opted to try and leave the Supra page in the Builders section as more of a quick reference, here's what you need to know, and then link to the tutorial for a deep dive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excellent idea on splitting the things into separate pages!
I also love the new scoped code snippet thingy 🤓
Description
This PR updates the Supra docs to apply Moonbeam standards and showcases a complete example of interacting with Supra.
The termynal snippet has text that flows outside of the window, so I created a companion PR for mkdocs that updates the styling so that it wraps to the next line: papermoonio/moonbeam-mkdocs#172
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in JiraAfter Translation Requirements