Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs on listing your project on the moonbeam dapp directory #875

Merged
merged 9 commits into from
Mar 8, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Feb 26, 2024

Description

This PR adds docs on listing a project on the Moonbeam DApp Directory!

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben added the A0 - New Content Pull request contains new content pages label Feb 26, 2024
themacexpert
themacexpert previously approved these changes Feb 26, 2024
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes but they are all pretty minor, page looks fantastic overall!

learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
.snippets/code/learn/dapps-list/dapp-directory/urls.json Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
themacexpert
themacexpert previously approved these changes Feb 28, 2024
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@albertov19
Copy link
Contributor

Let's wait for Aaron to check this out

@eshaben
Copy link
Contributor Author

eshaben commented Mar 5, 2024

@aaron2048 can you please review this when you have time? thanks! 🙂

@eshaben eshaben requested a review from aaron2048 March 5, 2024 15:01
@eshaben
Copy link
Contributor Author

eshaben commented Mar 8, 2024

@albertov19 I applied the feedback provided by Aaron, can you please check out the changes?

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey looks great!!!

Minor comments only, great job!

learn/dapps-list/dapp-directory.md Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
.snippets/code/learn/dapps-list/dapp-directory/urls.json Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
learn/dapps-list/dapp-directory.md Outdated Show resolved Hide resolved
eshaben and others added 2 commits March 8, 2024 10:46
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
@eshaben eshaben requested a review from albertov19 March 8, 2024 15:56
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit 3c30c07 into master Mar 8, 2024
1 check passed
@eshaben eshaben deleted the eshaben/dapp-directory branch March 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants