Girazoki supported fee payment assets storage #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-maintenance' into girazoki-xcm-max-ump-weight-migration
…runtime-pallet-maintenance
…t-maintenance' into girazoki-xcm-max-ump-weight-migration
girazoki
added
the
B7-runtimenoteworthy
…d-fee-payment-assets-storage
…d-fee-payment-assets-storage
notlesh
reviewed
Feb 21, 2022
| pub struct PopulateSupportedFeePaymentAssets<T>(PhantomData<T>); | ||
| impl<T: Config> OnRuntimeUpgrade for PopulateSupportedFeePaymentAssets<T> { | ||
| fn on_runtime_upgrade() -> Weight { | ||
| log::info!(target: "PopulateSupportedFeePaymentAssets", "actually running it"); |
There was a problem hiding this comment.
These log statements are potentially helpful (I think this is copy-pasted from other migrations) but we could probably rephrase them to have more helpful context. Maybe not info, too...?
notlesh
reviewed
Feb 21, 2022
notlesh
reviewed
Feb 21, 2022
notlesh
reviewed
Feb 21, 2022
notlesh
reviewed
Feb 21, 2022
|
no worries this is not as high priority as the others and can be included in 1400 |
…d-fee-payment-assets-storage
…d-fee-payment-assets-storage
…d-fee-payment-assets-storage
librelois
requested changes
Feb 22, 2022
There was a problem hiding this comment.
AssetType impl Ord, so use binary_search instead of push, see: https://substrate.recipes/vec-set.html
It will allow to find more quickly if an assettype is present or not, in O(log n) instead of O(n)
librelois
approved these changes
Feb 22, 2022
…d-fee-payment-assets-storage
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a storage with a vec of the supported fee payment assets.
This storage is read when receiving an incoming xcm message, and if the asset is not in this vec, the xcm message is not processed.
This is an improvement with respect to what we had because this storage item will be cached during the first read per block, therefore limiting a potential free DB DOS attack to the number of assets supported
What important points reviewers should know?
Target: runtime 1300
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?