Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOON-1737] adds IdentityJudgement Proxy type support #1597

Merged
merged 8 commits into from
Jun 20, 2022

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jun 13, 2022

What does it do?

adds IdentityJudgement Proxy type support

What important points reviewers should know?

Using kusama as reference

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 13, 2022
@crystalin
Copy link
Collaborator

crystalin commented Jun 13, 2022

Maybe adding 1 or 2 ts tests for this would be good too :)

@nbaztec
Copy link
Contributor Author

nbaztec commented Jun 13, 2022

Maybe adding 1 or 2 ts tests for this would be good too :)

Yeah posted in channel, need help regarding it

@nbaztec nbaztec merged commit beb2c99 into master Jun 20, 2022
@nbaztec nbaztec deleted the nish-add-identity branch June 20, 2022 14:21
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants