Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOON-2006] change log level for failing to auto-compound to debug #1935

Merged
merged 1 commit into from Nov 9, 2022

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Nov 8, 2022

What does it do?

Changes log level for failing to auto-compound to debug

What important points reviewers should know?

Failure to auto-compound is the normal behavior if a pending revoke exists, and hence shouldn't be treated as an error.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 8, 2022
@nbaztec nbaztec merged commit ca83b59 into master Nov 9, 2022
@nbaztec nbaztec deleted the nish-auto-compound-log branch November 9, 2022 14:54
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants