Change Author Slot Filter to rely on pallet_randomness (Moonbase only) #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
added
the
B7-runtimenoteworthy
nbaztec
commented
Nov 16, 2022
4meta5
reviewed
Nov 16, 2022
4meta5
reviewed
Nov 16, 2022
nbaztec
added
the
D9-needsaudit👮
crystalin
approved these changes
Nov 25, 2022
librelois
reviewed
Nov 25, 2022
librelois
requested changes
Nov 25, 2022
librelois
reviewed
Nov 25, 2022
librelois
reviewed
Nov 25, 2022
nbaztec
changed the title
librelois
approved these changes
Nov 25, 2022
notlesh
reviewed
Nov 28, 2022
notlesh
approved these changes
Nov 29, 2022
Co-authored-by: Stephen Shelton <steve@brewcraft.org>
…take/moonbeam into nish-randomness-author-slot-filter
notlesh
reviewed
Dec 20, 2022
| /// 2. First 2 bytes of index.to_le_bytes() when selecting the ith eligible author | ||
| /// 3. First 4 bytes of slot_number.to_be_bytes() | ||
| /// | ||
| /// Note: This needs to be updated when asynchronous backing is in effect, |
There was a problem hiding this comment.
:D I'm agnostic here. Will create a tracking ticket for it anyhow. Not a huge fan of TODOs if they're not currently actionable.
Didn't we wanna remove TODOs from our codebase though?
4meta5
approved these changes
Dec 20, 2022
notlesh
added
D1-audited👍
crystalin
changed the title
crystalin
changed the title
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
…nbeam-foundation#1956) * attempt using pallet_randomness for auth_slot_filter * use subject with local vrf output for randomness * fix slice copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
attempts using pallet_randomness for auth_slot_filter.
The randomness seed is the
LocalVrfOutputof the previous block, salted with the subject, which includes the relay block number for collision prevention when the vrf output does not change (in case block production is skipped).The genesis block will have the default
0x00...value of the hash.Breaking
This changes might break tools monitoring Author selection as it now relies on a different input (from collective flip previously, to moonbeam pallet randomness) to ensure the correct author
What important points reviewers should know?
pallet-randomness-collectiveuses a low-entropy randomness, while LocalVRF is high-entropy (allegedly). This should ideally be okay IMO since high-entropy yields a better randomness.Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?