impl ed25519 backward compatibility #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
girazoki
approved these changes
Dec 1, 2022
nanocryk
approved these changes
Dec 2, 2022
tgmichel
reviewed
Dec 5, 2022
| #[cfg(feature = "moonbeam-native")] | ||
| impl ExecutorT for MoonbeamExecutor { | ||
| fn first_block_number_compatible_with_ed25519_zebra() -> Option<u32> { | ||
| Some(2_000_000) |
There was a problem hiding this comment.
If I understand correctly, this block numbers are meant to indicate the height at which a substrate version changing ed25519 library was introduced in each runtime. Just to verify, are this block numbers (2_000_000, 3_000_000) correct?
There was a problem hiding this comment.
this block numbers are meant to indicate the height at which a substrate version changing ed25519 library was introduced in each runtime
No, this block number indicates from which block the behavior of the host function should change, knowing that this only applies when synchronizing past blocks. Normally our runtimes are "compatible" with the new behavior since runtime 1100, but for safety we take a more recent block.
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
* update substrate fork * impl backward ed25519 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The host function
ed25519_verifyhas changed its behavior in the substrate history, because of the change from libed25519-dalekto libed25519-zebra, which handles certain cases differently (at least the "zeroed" case).moon* networks have old blocks that are not compatible with
ed25519-zebra, this PR introduce a backward compatibility mechanism that allow to use the old lib (ed25519-dalek) to synchronize old blocks.To be able to do that, we use the new extension
UseDalekExt: paritytech/substrate#12661What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?