Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Tech Committee #2028

Merged
merged 29 commits into from Jan 17, 2023
Merged

Add Open Tech Committee #2028

merged 29 commits into from Jan 17, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jan 4, 2023

What does it do?

adds gov2 tech committee

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki
Copy link
Collaborator

girazoki commented Jan 5, 2023

It might also be good to initialize it in chain spec for testing purposes

@nbaztec nbaztec marked this pull request as ready for review January 5, 2023 16:26
@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jan 5, 2023
@nbaztec nbaztec added the not-breaking Does not need to be mentioned in breaking changes label Jan 5, 2023
Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Moonriver with same parameters (it needs both to have MotionDuration to 14 days)

runtime/moonbase/src/governance/councils.rs Outdated Show resolved Hide resolved
@librelois librelois mentioned this pull request Jan 17, 2023
19 tasks
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbaztec one of my changes was lost when you merged master, please add OpenTechCommitteeInstance in function is_governance_precompile

nbaztec and others added 2 commits January 17, 2023 17:43
@librelois librelois merged commit 7cfd317 into master Jan 17, 2023
@librelois librelois deleted the nish-gov2-committee branch January 17, 2023 19:18
@crystalin crystalin changed the title add gov2 tech committee Add Open Tech Committee Jan 20, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 8, 2023
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
* add gov2 tech committee

* integrate gov2 tech committee

* adapt params

* add to precompiles

* lint

* lint

* Increase motion duration to match voting period

* update evm proxy filter

* Add cautionary comments on proxy filters

* fix rust tests

* fmt

* update evm filter any

* change precompile address (to let rooms to other opengov precompiles)

* add OpenTechCommittee to moonriver

* add council files

* use consistent indices

* fix test

* Update runtime/moonriver/src/governance/councils.rs

* fmt

* bump

* Update runtime/moonbase/src/lib.rs

Co-authored-by: Éloïs <c@elo.tf>

* fix regression

* fmt

* fix typo

* fix import

* fix build

Co-authored-by: Alan Sapede <alan@purestake.com>
Co-authored-by: librelois <c@elo.tf>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants