Start minimal relay node if relay_chain_rpc_url is set
#2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
notlesh
reviewed
Jan 17, 2023
Comment on lines
+815
to
+822
| info!( | ||
| "Is collating: {}", | ||
| if config.role.is_authority() { | ||
| "yes" | ||
| } else { | ||
| "no" | ||
| } | ||
| ); |
There was a problem hiding this comment.
This is one of my favorite use cases for the ternary operator:
Suggested change
| info!( | |
| "Is collating: {}", | |
| if config.role.is_authority() { | |
| "yes" | |
| } else { | |
| "no" | |
| } | |
| ); | |
| info!("Is collating: {}", config.role.is_authority() ? "yes" : "no"); | |
|
@purestakeoskar has tested a client based on this PR and it works! We should include it in the next client (v0.29.0) |
notlesh
approved these changes
Jan 17, 2023
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
…undation#2042) * feat: start minimal relay node is relay_chain_rpc_url is set * editorconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In #1388 we mapped the new cumulus cli option
relay_chain_rpc_url, believing that this was enough.But it is also necessary to change the way the relay node is setup, which is the purpose of this PR.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?