Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow "ANY proxy" to call to any EVM address #2098

Merged
merged 2 commits into from Feb 15, 2023
Merged

allow "ANY proxy" to call to any EVM address #2098

merged 2 commits into from Feb 15, 2023

Conversation

tmpolaczyk
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tmpolaczyk tmpolaczyk added the B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes label Feb 14, 2023
@nbaztec nbaztec added D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Feb 14, 2023
librelois
librelois requested changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to allow any evm call, so just replace the whole block by ProxyType::Any => true

@tmpolaczyk tmpolaczyk merged commit f9e141b into master Feb 15, 2023
@tmpolaczyk tmpolaczyk deleted the tomasz-any-any branch February 15, 2023 14:52
@tmpolaczyk tmpolaczyk mentioned this pull request Mar 6, 2023
Merged
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 26, 2023
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
@tmpolaczyk @imstar15
allow "ANY proxy" to call to any EVM address (moonbeam-foundation#2098)
87d55c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tmpolaczyk @librelois @nbaztec @notlesh