Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomness pallet as author filter source to moonbeam #2135

Merged
merged 3 commits into from Mar 2, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Feb 27, 2023

What does it do?

Adds randomness pallet as author filter source to moonbeam. Follow up of #2087

What important points reviewers should know?

This also removes pallet-randomness-collective-flip as it's no longer used.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Feb 27, 2023
Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like another review

@nbaztec nbaztec merged commit 0f7d8a3 into master Mar 2, 2023
@nbaztec nbaztec deleted the nish-author-filter-random branch March 2, 2023 15:47
@crystalin crystalin changed the title [MOON-2124] add randomness pallet as author filter source to moonbeam Add randomness pallet as author filter source to moonbeam Apr 13, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 26, 2023
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
…, remove pallet-randomness-collective-flip (moonbeam-foundation#2135)

* use pallet randomness for pallet author slot filter

* remove pallet randomness collective flip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants