-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HRMP Cancel variant to hrmp_manage #2159
Conversation
I dont think Adding an enum variant is a breaking change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Maybe you can add the variant to https://github.com/PureStake/moonbeam/blob/master/precompiles/relay-encoder/RelayEncoder.sol too. Or we can leave it for a future pr |
I will open a new ticket and a new PR for that, to decouple changes a bit more. |
* hrmp_manage modified - allow to cancel a request * hrmp_manage - added Cancel variant to HrmpOperation * added unit test for Cancel variant (hrmp) * cargo fmt * fixed parachain runtime files within xcm_mock * fixed params and index of Cancel variant * added test_hrmp_cancel unit test within encoders * fixed test_relay_runtime in precompiles
What does it do?
This PR introduces the possibility to cancel a request within
hrmp_manage()
extrinsic present inxcm-transactor
pallet.Changes
Cancel
variant toHrmpOperation
enum.CancelOpenChannel
variant toHrmpAvailableCalls
enum.hrmp_encode_call()
implementation of polkadot, kusama and westend relay encoders to accept these new variants.