Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify RelayEncoder precompile to accept HRMP Cancel variant #2179

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Modify RelayEncoder precompile to accept HRMP Cancel variant #2179

merged 3 commits into from
Mar 23, 2023

Conversation

Agusrodri
Copy link
Contributor

What does it do?

Taking into account this previous PR #2159, this new PR adds the possibility to access the HRMP CancelOpenRequest variant through relay-encoder precompile.

Changes

  • Added encodeHrmpCancelOpenRequest() function to both RelayEncoder.sol interface and RelayEncoderInstance.sol contract.
  • Added encode_hrmp_cancel_open_request() function within relay-encoder precompile lib.rs file.
  • Modified RelayEncoder.json and RelayEncoderInstance.json files within tests/contracts/compiled to accept the new function and its corresponding selector.

@Agusrodri Agusrodri marked this pull request as draft March 22, 2023 19:28
@Agusrodri Agusrodri added D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes labels Mar 22, 2023
@Agusrodri Agusrodri marked this pull request as ready for review March 22, 2023 21:10
@Agusrodri Agusrodri merged commit bf1eafc into master Mar 23, 2023
@Agusrodri Agusrodri deleted the agustin-relay-encoder-refactor branch March 23, 2023 13:17
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@Agusrodri @imstar15
Modify RelayEncoder precompile to accept HRMP Cancel variant (moonbea…
74e049b 
…m-foundation#2179)

* changed Cancel variant name

* added Cancel variant to RelayEncoder

* fixed parachain files within runtimes xcm_mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Agusrodri @girazoki @librelois @notlesh