Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckNonZeroSender on SignedExtra #2172

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Mar 20, 2023

What does it do?

This PR adds the CheckNonZeroSender check within SignedExtra type on each runtime (Moonbase, Moonriver, Moonbeam). This prevent an extrinsic to be signed by the zero address.

Changes

  • Added CheckNonZeroSender to SignedExtra type.
/// The SignedExtension to the basic transaction logic.
pub type SignedExtra = (
        frame_system::CheckNonZeroSender<Runtime>,
	frame_system::CheckSpecVersion<Runtime>,
	frame_system::CheckTxVersion<Runtime>,
	frame_system::CheckGenesis<Runtime>,
	frame_system::CheckEra<Runtime>,
	frame_system::CheckNonce<Runtime>,
	frame_system::CheckWeight<Runtime>,
	pallet_transaction_payment::ChargeTransactionPayment<Runtime>,
);

⚠️ Breaking Change ⚠️

The runtime is not accepting anymore the 0x000...000 address as a valid sender

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Mar 20, 2023
@Agusrodri Agusrodri merged commit e7fc2a7 into master Mar 20, 2023
@Agusrodri Agusrodri deleted the agustin-checkNonZeroSender branch March 20, 2023 16:09
@crystalin crystalin added breaking Needs to be mentioned in breaking changes and removed not-breaking Does not need to be mentioned in breaking changes labels Apr 13, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
* added CheckNonZeroSender on SignedExtra

* fixed order within SignedExtra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants